git/caesar-transfer
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

76 add transfer struct to appstate #78

Merged
PatrykHegenberg merged 1 commit from 76-add-transfer-struct-to-appstate into 51-implement-local-data-transfer 2024-04-28 13:59:00 +02:00
Conversation 0 Commits 1 Files changed 2 +7 -6
PatrykHegenberg commented 2024-04-28 13:58:02 +02:00 (Migrated from github.com)
Copy link

Description

Added the Transfer struct to AppState.

Motivation and Context

To keep hold of all transfers and share them between connections, it is necessary to add the transfer struct to the AppState.
Closes #76 .

How Has This Been Tested?

Adapted unit test for creating new AppState.
Additionally tested manually.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
## Description Added the Transfer struct to AppState. ## Motivation and Context To keep hold of all transfers and share them between connections, it is necessary to add the transfer struct to the AppState. Closes #76 . ## How Has This Been Tested? Adapted unit test for creating new AppState. Additionally tested manually. ## Screenshots / Logs (if applicable) ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation (no code change) - [ ] Refactor (refactoring production code) - [ ] Other <!--- (provide information) --> ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [x] I have updated the documentation accordingly. - [x] I have formatted the code with [rustfmt](https://github.com/rust-lang/rustfmt). - [x] I checked the lints with [clippy](https://github.com/rust-lang/rust-clippy). - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. <!--- Thank you for contributing! -->
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
First base implementation to build on
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: git/caesar-transfer#78
No description provided.
Delete branch "76-add-transfer-struct-to-appstate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?